[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: a type fix, obstack_print
From: |
Eric Blake |
Subject: |
Re: a type fix, obstack_print |
Date: |
Sat, 23 Feb 2008 09:00:35 -0700 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Ralf Wildenhues on 2/23/2008 3:17 AM:
| Hi Eric,
Hi Ralf,
|
| FWIW, I think the use of different integer types for lenghts looks a bit
| messy in arg_print and the functions it calls. This patch fixes the one
| incompatible type (which will do the wrong thing on x86_64) on
| branch-1_4.
Aargh. Copy-n-paste bit me; where I modified the patch when porting to
head (which uses size_t consistently), then pulled those modifications
back to the branch (which, as you noticed, was mostly using int). I think
I'll go one step further, and make the branch consistently use size_t for
- --arglength and truncation.
|
| It also renames obstack_print, to not clash with obstack.h's name space
| (I mistakenly thought at first that this was a function provided by the
| obstack module).
Reasonable idea, especially since a while ago, I discussed the idea of
porting glibc's obstack_printf to gnulib (but have not done so, to date).
~ But on the head, I named the comparable M4 function
m4_shipout_string_trunc rather than obstack_print, so maybe I'll use a
name along those lines. I'll get something committed later today.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHwEMj84KuGfSFAYARAl+DAJ9sCuwpodOl/M26C3gHTRke1lsFCACghI+6
5KLJ1oK2b+2vSahYtFeut24=
=8wSt
-----END PGP SIGNATURE-----