Drop ltdl configure banner (was: use build-aux)

[Ralf Wildenhues]

Hello Eric,

* Eric Blake wrote on Tue, Nov 06, 2007 at 02:30:41PM CET:
> According to Eric Blake on 11/6/2007 6:15 AM:
> > According to Ralf Wildenhues on 11/6/2007 4:31 AM:
> >> You need to ensure build-aux/mkstamp exists at the end of the bootstrap.
> >> You could copy it from ltdl/config/.
> > 
> > Or is there a better way to make libtool share build-aux, rather than
> > creating its own subdirectory?  Perhaps using the libtoolize
> > --nonrecursive or --recursive option?
> 
> Nevermind.  I see that I missed a file; I wrote the above thinking that
> mkstamp belonged to libtool, but see now that it belongs to m4.  Applying:

But libltdl makes use of mkstamp as well, see ltdl/configure.ac:

# This is a sanity check so we can see which version is used in bug reports.
# It is assumed that we only want to see the date extension for cvs libtool
# versions (i.e. "odd" letters) and not actual alpha releases.
TIMESTAMP=
case $lt_alpha in
  [[acegikmoqsuwy]])
    TIMESTAMP=`${CONFIG_SHELL} ${ac_aux_dir}/mkstamp < ${srcdir}/ChangeLog`
    AS_BOX([Configuring AC_PACKAGE_TARNAME (Build:$TIMESTAMP) 
AC_PACKAGE_VERSION])
    echo
    ;;
esac
AC_SUBST([TIMESTAMP])

Hmm, that code is broken: lt_alpha is not set, and ltdl should just ship
with mkstamp.  OTOH, I must say that I don't like this banner in libltdl
much: we haven't displayed it in a long time, other users of libltdl
have their own ways of printing banners so this would look a bit ugly
for them, and the libltdl version used is always shown in the head of
config.log.

Any reason not to apply this patch to Libtool HEAD?

Cheers,
Ralf

2007-11-07  Ralf Wildenhues  <address@hidden>

        * libltdl/configure.ac: Drop the broken and long-disabled code
        to output a banner for the libltdl configure.  Avoids the need
        to ship mkstamp with libltdl.

Index: libltdl/configure.ac
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/configure.ac,v
retrieving revision 1.21
diff -u -r1.21 configure.ac
--- libltdl/configure.ac        25 Mar 2007 12:12:42 -0000      1.21
+++ libltdl/configure.ac        8 Nov 2007 18:26:54 -0000
@@ -1,6 +1,6 @@
 # Process this file with autoconf to create configure. -*- autoconf -*-
 #
-#    Copyright (C) 2004, 2005 Free Software Foundation, Inc.
+#    Copyright (C) 2004, 2005, 2007 Free Software Foundation, Inc.
 #    Written by Gary V. Vaughan, 2004
 #
 #    NOTE: The canonical source of this file is maintained with the
@@ -48,30 +48,13 @@
 LT_CONFIG_LTDL_DIR([.]) # I am me!
 
 
-## ---------------------------------------- ##
-## Display a configure time version banner. ##
-## ---------------------------------------- ##
-
-# This is a sanity check so we can see which version is used in bug reports.
-# It is assumed that we only want to see the date extension for cvs libtool
-# versions (i.e. "odd" letters) and not actual alpha releases.
-TIMESTAMP=
-case $lt_alpha in
-  [[acegikmoqsuwy]])
-    TIMESTAMP=`${CONFIG_SHELL} ${ac_aux_dir}/mkstamp < ${srcdir}/ChangeLog`
-    AS_BOX([Configuring AC_PACKAGE_TARNAME (Build:$TIMESTAMP) 
AC_PACKAGE_VERSION])
-    echo
-    ;;
-esac
-AC_SUBST([TIMESTAMP])
-
-
 ## ------------------------ ##
 ## Automake Initialisation. ##
 ## ------------------------ ##
 
 AM_INIT_AUTOMAKE([gnits])
 
+
 ## ------------------------------- ##
 ## Libtool specific configuration. ##
 ## ------------------------------- ##