Re: HEAD: inclusion order wrong for input.c

[Gary V. Vaughan]

Hi Eric,

On 3 Apr 2007, at 05:10, Eric Blake wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> According to Ralf Wildenhues on 4/2/2007 11:45 AM:
> > * Gary V. Vaughan wrote on Mon, Apr 02, 2007 at 02:32:45PM CEST:
> > >  Thanks for the report.  Although I don't get this warning, I  
> > > have cleaned
> > >  up the remaining warnings that I did see on OS X.
> >
> > Thanks, looking better now.  I do get these warnings now, with -Wall:
> >
> > ../m4/m4/macro.c: In function 'expand_macro':
> > ../m4/m4/macro.c:279: warning: format '%d' expects type 'int', but  
> > argument 5 has type 'size_t'
> > ../m4/m4/macro.c: In function 'process_macro':
> > ../m4/m4/macro.c:425: warning: array subscript has type 'char'
> > ../m4/m4/macro.c:478: warning: array subscript has type 'char'
> >
> > ../m4/src/freeze.c: In function ‘produce_resyntax_dump’:
> > ../m4/src/freeze.c:97: warning: format ‘%d’ expects type ‘int’,  
> > but argument 3 has type ‘size_t’
>
> This fixes these warnings; gnulib makes it possible to assume %z  
> nowadays.

Okay cool :-)

2 Patches though please.  One for %z fixes.

> 2007-04-02  Eric Blake  <address@hidden>
>
>         Fix warnings from last commit.
>         * ltdl/m4/gnulib-cache.m4: Augment with 'gnulib-tool --import
>         fprintf-posix sprintf-posix'.
>         * m4/macro.c (expand_macro, trace_format): Use correct specifier
>         for size_t.
>         * src/freeze.c (produce_resyntax_dump, produce_module_dump)
>         (dump_symbol_CB, produce_frozen_state): Use correct specifier for
>         size_t.

And another (preferably with analogous changes when building the table)
for array indexing fixes:

>         (process_macro): Avoid negative array index.

Cheers,
        Gary
--
  ())_.              Email me: address@hidden
  ( '/           Read my blog: http://blog.azazil.net
  / )=         ...and my book: http://sources.redhat.com/autobook
`(_~)_ Join my AGLOCO Network: http://www.agloco.com/r/BBBS7912

PGP.sig
Description: This is a digitally signed message part