Re: testsuite: distributed depending on non-distributed

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Ralf Wildenhues on 9/12/2006 2:08 AM:
> Hello Eric,
> 
> * Eric Blake wrote on Fri, Sep 08, 2006 at 05:44:16PM CEST:
>> With that fixed, and this additional patch, make distcheck works again
>> when TESTSUITEFLAGS is set to avoid the failing defn test (and on cygwin,
>> [...])
> 
> FWIW, I don't get a distcheck pass: installcheck fails all module
> related tests for me on GNU/Linux, because the `modtest' module
> is not found.  Also, test 24 (--debug) fails; see below.

Thanks for the report.  Both of these are a PATH issue.  The testsuite
currently expects to execute tests/m4 (built from tests/m4.in), which
invokes the real m4 with -M modules (so it can find modtest), and which
normalizes stderr.  But on installcheck, we are altering PATH to pick up
the installed m4, and bypassing the wrapper.  I was not seeing the
failures because I was skipping too many tests (I ran with
TESTSUITEFLAGS=1, instead of TESTSUITEFLAGS='-59 61-').  Perhaps the thing
to do here would be renaming tests/m4 to tests/m4wrap, altering
AT_CHECK_M4 to call tests/m4wrap, and then having the wrapper script pick
up the correct m4 from the PATH.  Or maybe follow autoconf's lead and do
all m4 output normalization inside testsuite.at.  Also, since modtest is
not installed, but currently lives in the same build directory as other
modules that do get installed, that makes it hard to tell if installcheck
is testing the installed module or the built one.  Maybe it is worth
splitting built modules into two directories, based on whether they will
be installed.

I'll have to play with this some, but hope to have a patch soon.

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFBq5r84KuGfSFAYARAqCrAJwOhQ03+SGW8GcaaYMcfj6v4rs5DwCcDFh2
hm2gAkLLTU02diXkd9nXpRg=
=UtMr
-----END PGP SIGNATURE-----