m4-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: several buglets in CVS m4


From: Ralf Wildenhues
Subject: Re: several buglets in CVS m4
Date: Mon, 19 Jun 2006 17:48:33 +0200
User-agent: Mutt/1.5.11

Hi Eric,

* Eric Blake wrote on Mon, Jun 19, 2006 at 05:42:39PM CEST:
> According to Ralf Wildenhues on 6/16/2006 1:33 AM:
> > 3) Automake creates build tree directory rules for the targets it writes
> > the rules for (the .dirstamp stuff), but not for manually written rules;
> > this needs to be done for doc/m4.1 (for a VPATH build).  Patch below,
> > written not to depend on the Automake internal detail .dirstamp.
> 
> Or better yet, treat *.1 like *.info and build it in $(srcdir), since it
> will already be up-to-date and safe for the read-only srcdir portion of
> 'make distcheck'.

Good.

> Applied as follows.  Cleanup of the bigger issue of M4ERROR output will
> have to come later.

OK, except for...

> --- src/freeze.c      16 Jun 2006 01:32:41 -0000      1.42
> +++ src/freeze.c      19 Jun 2006 15:34:07 -0000
> @@ -338,7 +338,7 @@ reload_frozen_state (m4 *context, const 
>    char syntax;
>    unsigned char *string[3];
>    int allocated[3];
> -  int number[3];
> +  int number[3] = {0};

this which won't initialize number[2].

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]