[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: module/time.c violates aliasing rules
From: |
Eric Blake |
Subject: |
Re: module/time.c violates aliasing rules |
Date: |
Sat, 10 Jun 2006 07:14:14 -0600 |
User-agent: |
Thunderbird 1.5.0.4 (Windows/20060516) |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Eric Blake on 6/8/2006 7:14 AM:
> Andreas Schwab <schwab <at> suse.de> writes:
>
>> modules/time.c: In function 'builtin_ctime':
>> modules/time.c:100: warning: dereferencing type-punned pointer will break
> strict-aliasing rules
>> This is guaranteed to fail on bigendian hosts with time_t > int.
>
> Thanks for the report. This patch is probably small enough to apply, but
> would
> you be willing to fill out copyright assignment for future patches? This,
> combined with your previous submissions, is starting to become non-trivial.
>
>> 2006-06-05 Andreas Schwab <schwab <at> suse.de>
>>
>> * modules/time.c (ctime): Pass correctly typed variable to
>> m4_numeric_arg.
>> (gmtime): Likewise.
>> (localtime): Likewise.
>> (strftime): Likewise.
>
Applied, plus a documentation tweak to m4/utility.c explaining the
arbitrary limitation. I want to pull in gnulib's xstrtoimax to fix the
real issue that you identified, namely that m4 is arbitrarily limiting
parsed integer input, but that will take more time.
- --
Life is short - so eat dessert first!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFEisWl84KuGfSFAYARAqkNAKCA6W24Tw1qvVtsKxme6C+T6Mp/zACdHp4g
DZ4zPKsLIvVUn48dEdKsNAE=
=ZKqE
-----END PGP SIGNATURE-----