[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Lzip-bug] Lziprecover --split is broken
|
From: |
Antonio Diaz Diaz |
|
Subject: |
Re: [Lzip-bug] Lziprecover --split is broken |
|
Date: |
Tue, 23 Jan 2018 20:43:19 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 |
Hello Hampa,
Hampa Hug wrote:
Splitting an lzip file using 'lziprecover -s' is currently
broken. This is because File_index::File_index() moves the file
offset of the input file. In do_split_file() the read buffer is
filled before File_index::File_index() is called and subsequent
reads continue at the wrong position. The attached patch fixes
this by moving the call to File_index::File_index() before the
call to seek_read().
Thank you very much for reporting this.
It is in fact a stupid bug introduced in version 1.16 that the testsuite
didn't caught because the test file was smaller than the buffer size.
I'll release a fixed version today.
Best regards,
Antonio.