Re: [Lynx-dev] Adding $SOCKS5_PROXY support, changing command line option

[Thorsten Glaser]

Steffen Nurpmeso dixit:

 |+     socks5_proxy = (char*)-1;

Don’t do that, that is not portable.

 |   cleanup:
 |-    if (socks5_proxy != NULL) {
 |+    if (socks5_proxy != (char*)-1) {
 |  FREE(socks5_new_url);
 |  FREE(socks5_protocol);
 |  FREE(socks5_host);

If this is just for freeing… free(3) takes NULL as no-op.
Otherwise, find a better way to flag this.

Your patch also changes something wrt. socks5_orig_url.

bye,
//mirabilos
-- 
Support mksh as /bin/sh and RoQA dash NOW!
‣ src:bash (389 (415) bugs: 1 RC, 264 (283) I&N, 124 (131) M&W, 0 F&P)
‣ src:dash (90 (105) bugs: 0 RC, 48 (52) I&N, 42 (53) M&W, 0 F&P)
‣ src:mksh (0 bugs: 0 RC, 0 I&N, 0 M&W, 0 F&P)
dash has two RC bugs they just closed because they don’t care about quality…