Re: [Lynx-dev] [bug] invalid gopher HTML links in 2.9.0dev.3

[Thomas Dickey]

On Tue, Aug 27, 2019 at 03:09:41PM +0200, Martijn Dekker wrote:
> Op 27-08-19 om 00:51 schreef Thomas Dickey:
> > On Mon, Aug 26, 2019 at 05:46:33PM +0200, Martijn Dekker wrote:
> > > Op 26-08-19 om 15:41 schreef Martijn Dekker:
> > > > In lynx 2.9.0dev.3, when going to:
> > > > gopher://gopher.metafilter.com/1/MetaFilter
> > > > 
> > > > all links point to broken addresses like:
> > > > gopher://gopher.metafilter.com:70:/hMetaFilter/Bom-bom-bi-bom-bi-dum-bum-bay.html
> > 
> > (sorry - I misread one of Tobias' examples)
> > 
> > > > whereas in 2.8.9rel.1 they point to correct addresses like:
> > > > gopher://gopher.metafilter.com/h/MetaFilter/Bom-bom-bi-bom-bi-dum-bum-bay.html
> > > 
> > > The attached patch restores 2.8.8rel.1 behaviour for me.
> > 
> > This is simpler (seems to work for me):
> [...]
> 
> In 2.9.0dev.4, those links are now like:
> 
> gopher://gopher.metafilter.com/hMetaFilter/This-is-what-patriotism-looks-like.html
> 
> i.e.: a missing '/' after the 'h'. That doesn't seem correct. But, oddly
> enough, it does actually load the pages with those URLs. What's up with
> that?

I'm not certain: I stripped the leading '/' (that you're referring to)
because otherwise it was substituted before the "GET", producing an
invalid fetch.

I did this to make the example that Tobias gave in April work properly.

I looked for details on the expected syntax of "h" in gophermap,
(for instance, in case the hex-encoding should have been kept there,
and undone in a later stage) but didn't find anything except for a
terse comment that it's an extension.  So I made the simplest fix -
just adjusting the menu.

In Tobias' report, he showed an example using the URL as a command-line
parameter (which worked), and from using "lynx -trace", I could see the
basic issue to solve.  I made a gophermap entry to test/develop with,
and modified lynx to produce the same sort of trace.

Here are the lines I added to /var/gopher/gophermap for testing dev.4:

htest-fail      GET /?p=1245    isticktoit.net  0
htest-ok        GET /?p=1245    isticktoit.net  80

-- 
Thomas E. Dickey <address@hidden>
https://invisible-island.net
ftp://ftp.invisible-island.net

signature.asc
Description: PGP signature