lynx-dev Re: [PATCH 2.8.5-dev15] table horizontal shift

[Ilya Zakharevich]

On Sun, Sep 28, 2003 at 03:44:14PM -0700, Ilya Zakharevich wrote:
> This fixes the last non-cosmetic bug with table layout - total table
> width was wrongly calculated due to skipping some "merged" lines when
> calculating the maximum.

This patch is also not included in dev16c7.

> --- src/GridText.c.orig       Sun Sep 28 10:41:38 2003
> +++ src/GridText.c    Sun Sep 28 13:12:38 2003
> @@ -4913,10 +4914,10 @@ PRIVATE int HText_insertBlanksInStblLine
>               deleted++;
>               /* Only one line is left is a special case */
>               if (me->last_line == me->last_line->next)
> -                 nextline = me->last_line;
> +                 nxt_line = nextline = me->last_line; /* XXX nxt_line 
> needed? */
>               if (line == first_line->next)
>                   first_line = nxt_line->prev;
> -             line = nextline->prev;
> +             line = nxt_line->prev;
>           } else if (do_unsplit) {    /* Need to shift horizontally */
>               int opos = 0, npos = do_unsplit;
>  

Additionally, one extra edit was missed:

--- ./src/TRSTable.c    Mon Oct  6 15:04:20 2003
+++ my/src/TRSTable.c   Sun Sep 28 10:44:08 2003
@@ -1705,8 +1705,6 @@ PUBLIC int Stbl_trimFakeRows ARGS3(
     if (me->nrows <= 0 || me->nrows <= me->last_reserved)
        return 0;
     lastrow = me->rows + (me->nrows - 1);
-    if (lastrow->ended != ROW_not_ended)
-       return -1;                      /* E.g., may be processing </tr> */
     icell = lastrow->ncells - 1;
     if (icell >= 0 && lastrow->cells[icell].cLine < lineno) {
        /* The last cell start on a preceeding line; keep lastrow */

With these 4 patches (2 were sent an hour ago) the table support in
lynx is up to what I had in my development directory.  It shows

  ilyaz.org/software/tmp/table-links_3x4.html
  ilyaz.org/software/tmp/table-test.html

correct.

Enjoy,
Ilya

; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden