Re: [Info-mtools] [PATCH] Fix mattrib does not work

[Alain Knaff]

Hi,

On 14/03/2023 10:07, zhanghongtao (A) via Info-mtools wrote:
> Subject: [PATCH] Fix mattrib does not work
> 
> For example:
> 
> #mattrib +r tmp_dos_test
> #echo $?
> 0
> #mattrib tmp_dos_test
>   A          A:/tmp_dos_test
> 
> mattrib didn't work.
> We found that the judgment in the attrib_file function was incorrect.

Thanks for the patch, this is now part of the new 4.0.43 release of mtools.


> 
> Signed-off-by: Hongtao Zhang <zhanghongtao22@huawei.com>
> ---
>  mattrib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mattrib.c b/mattrib.c
> index 29ef1da..e5cac78 100644
> --- a/mattrib.c
> +++ b/mattrib.c
> @@ -34,7 +34,7 @@ static int attrib_file(direntry_t *entry, MainParam_t *mp)
>  {
>         Arg_t *arg=(Arg_t *) mp->arg;
> 
> -       if(isRootEntry(entry)) {
> +       if(!isRootEntry(entry)) {
>                 /* if not root directory, change it */
>                 entry->dir.attr = (entry->dir.attr & arg->remove) | arg->add;
>                 dir_write(entry);
> --
> 2.39.1
> 

Thanks,

Alain