[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#74689] [PATCH v2 1/3] Partial revert "gnu: make-bootstrap: Update g
From: |
Janneke Nieuwenhuizen |
Subject: |
[bug#74689] [PATCH v2 1/3] Partial revert "gnu: make-bootstrap: Update gcc-static to gcc-14, for the 64bit Hurd." |
Date: |
Wed, 04 Dec 2024 18:05:08 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Zheng Junjie writes:
> This partially reverts commit ec8a5ec15f898e864705e5a5c834532e3fa8d0a4.
>
> This part accidentally triggered a world rebuild for non-x86 architectures.
>
> Change-Id: Id2f9bcbcda8dc86ea407e9a7857a854dc1a742b5
> ---
> gnu/packages/make-bootstrap.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/make-bootstrap.scm b/gnu/packages/make-bootstrap.scm
> index e0dcca7b33e..7e124f487ed 100644
> --- a/gnu/packages/make-bootstrap.scm
> +++ b/gnu/packages/make-bootstrap.scm
> @@ -538,7 +538,8 @@ (define %gcc-static
> (substitute* (cons "gcc/config/rs6000/sysv4.h"
> (find-files "gcc/config"
> "^gnu-user.*\\.h$"))
> - ((" -lgcc_s}}") "}}"))))))))
> + ((" -lgcc_s}}") "}}")
> + #$@(if (target-hurd64?) '() '(#t)))))))))
I don't see how this would work for you, the #t ends up inside the
(substitute ...), you want it outside, no? So, with this extra
change:
--8<---------------cut here---------------start------------->8---
diff --git a/gnu/packages/make-bootstrap.scm b/gnu/packages/make-bootstrap.scm
index 7e124f487e..59c117f226 100644
--- a/gnu/packages/make-bootstrap.scm
+++ b/gnu/packages/make-bootstrap.scm
@@ -538,8 +538,8 @@ (define %gcc-static
(substitute* (cons "gcc/config/rs6000/sysv4.h"
(find-files "gcc/config"
"^gnu-user.*\\.h$"))
- ((" -lgcc_s}}") "}}")
- #$@(if (target-hurd64?) '() '(#t)))))))))
+ ((" -lgcc_s}}") "}}"))
+ #$@(if (target-hurd64?) '() '(#t))))))))
(inputs
`(("zlib:static" ,zlib "static")
("isl:static" ,isl "static")
--8<---------------cut here---------------end--------------->8---
Other than this, LGTM
--
Janneke Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com
- [bug#74689] [PATCH 1/3] Partial revert "gnu: make-bootstrap: Update gcc-static to gcc-14, for the 64bit Hurd.", (continued)
[bug#74689] [PATCH 2/3] Partial revert "gnu: bootstrap: %bootstrap-glibc: Also fix libm.so.", Zheng Junjie, 2024/12/04
[bug#74689] [PATCH v2 1/3] Partial revert "gnu: make-bootstrap: Update gcc-static to gcc-14, for the 64bit Hurd.", Zheng Junjie, 2024/12/04
bug#74689: [PATCH 0/3] fix non-x86 world rebuild, Ludovic Courtès, 2024/12/10