[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#57291] New package: fftgen
From: |
Maxime Devos |
Subject: |
[bug#57291] New package: fftgen |
Date: |
Fri, 2 Sep 2022 20:57:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 |
On 19-08-2022 01:18, Gabriel Wicki wrote:
+ (file-name (git-file-name name
+ (string-take commit 8)))
You don't have to string-take, the standard pattern is (git-file-name
name version), as in (guix)Version Numbers.
+ `(#:tests? #f
Why are tests disabled? There is a bench-test target, maybe you need
#:test-target "bench-test"? I hope that means "test bench" and not
"benchmark" though.
On the license: some parts are GPL3+ (see:
https://github.com/ZipCPU/dblclockfft/blob/master/sw/legal.h), that
sounds important to add to the license field to me (license
(license:lgpl3+ license:gpl3+)).
Greetings,
Maxime.
OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug#57291] New package: fftgen,
Maxime Devos <=