Re: [PATCH] test-suite: Add tests for `for-rdelim-in-port`-relatedfunctions.

[Mikael Djurfeldt]

Hi Maxime,

On Fri, Dec 20, 2024 at 4:15 PM Maxime Devos <maximedevos@telenet.be> wrote:

> Thanks for your patches! Applied now.

 

Regardless of the question whether to generalise, there was also the thing about the test testing for returning #true even though this behaviour isn’t documented anywhere.

Maybe there's a misunderstanding here: What Adams test does is to compile a list of results. What he refers to is the #t returned by the test checking that the compiled results are correct. I changed that wording. Otherwise, I think the test is fine (on a Unix system).

 

Also, there was the thing about needing to verify whether (ice-9 rdelim) always recognises \n or whether that’s Unix-dependent (if the latter, (ice-9 rdelim) or the test needs to be adjusted, and in case of the former the documentation needs to be adjusted).

You're right that the behavior is Unix-dependent, as is the behavior of read-line! in the same file. Perhaps one should do something about that. If so, the entire (ice-9 rdelim) module needs to be revised as well as libguile/rdelim.c since the current implementation assumes that the line delimiter is a single character, which was not true under Windows last time I checked.

Best regards,

Mikael