RE: [External] : Re: [PATCH] Allow background to be set when theme is set

[Alec Brown]

Hey,

So a few suggestions. You should use git send-email to send your patch. This
will format the patch nicely and make it easier to apply your patch to the rest
of the GRUB code. Also, when sending an update of your patch, instead of
replying to the initial patch, you should send a separate email with an updated
version number, i.e. [PATCH v2]. You will also need a signed-off-by at the end
of your commit message for the patch.

Alec Brown

On Tue, Oct 22, 2024 at 2:50 PM, Lin <maud-lin@gmx.de> wrote:
> On 13.06.24 17:28, Lin wrote:
> >
> > Hello, first time contributor here.
> > I'm not experienced with mailing lists and mailing patches so just let
> > me know if I do anything wrong :)
> >
> > This patch simply allows that if GRUB_BACKGROUND and GRUB_THEME is set
> > at the same time, both pieces of code gets generated into grub.cfg by
> > grub-mkconfig.
> >
> > If a theme is loaded, the background image will be visible inside the
> > console.
> >
> Already made my first mistake and got my patch reversed lol. Corrected
> patch is below.
> 
> Again, when setting a GRUB_THEME, the elif disallows the GRUB_BACKGROUND
> to be used, yet with my patch applied a set background image will not
> interfere with the theme, but only be visible as the background for the
> console when opened with 'c'.
> 
> Thanks,
> Lin
> 
> 
> diff --git a/util/grub.d/00_header.in b/util/grub.d/00_header.in
> index f86b69bad..4e8f25702 100644
> --- a/util/grub.d/00_header.in
> +++ b/util/grub.d/00_header.in
> @@ -263,7 +263,9 @@ EOF
>   set theme=(\$root)`make_system_path_relative_to_its_root $GRUB_THEME`
>   export theme
>   EOF
> -    elif [ "x$GRUB_BACKGROUND" != x ] && [ -f "$GRUB_BACKGROUND" ] \
> +    fi
> +
> +    if [ "x$GRUB_BACKGROUND" != x ] && [ -f "$GRUB_BACKGROUND" ] \
>           && is_path_readable_by_grub "$GRUB_BACKGROUND"; then
>       gettext_printf "Found background: %s\n" "$GRUB_BACKGROUND" >&2
>       case "$GRUB_BACKGROUND" in
> 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://urldefense.com/v3/__https://lists.gnu.org/mailman/listinfo/grub-
> devel__;!!ACWV5N9M2RV99hQ!PLGidopsW7qPo_wRq33QaUvrp0eXPF-
> Qo0P_D2qJ8UL7kJdBXudmjssK0vWbpxFukgrhEoPThYgtOPZhaSDX$