[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 12/22] release: tests: make it pass shellcheck.
From: |
Denis 'GNUtoo' Carikli |
Subject: |
[PATCH v1 12/22] release: tests: make it pass shellcheck. |
Date: |
Fri, 20 Dec 2024 22:24:07 +0100 |
Without this fix, running shellcheck -x on
resources/packages/release/test shows the following error:
In resources/packages/release/test line 200:
missing_in_release_files=$(expr $missing_in_release_files + 1)
^--^ SC2003 (style): expr is antiquated.
Consider rewriting this using $((..)), ${} or [[ ]].
^-----------------------^ SC2086
(info): Double quote to prevent globbing and word splitting.
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
---
resources/packages/release/test | 2 +-
tests/lint | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/resources/packages/release/test b/resources/packages/release/test
index 63d3f5af..35ecedb7 100755
--- a/resources/packages/release/test
+++ b/resources/packages/release/test
@@ -197,7 +197,7 @@ test_release_dir()
if [ $found -eq 0 ] ; then
echo "[ !! ] $path missing in \${release_files}"
- missing_in_release_files=$(expr $missing_in_release_files + 1)
+ missing_in_release_files="$((missing_in_release_files + 1))"
fi
done < <(find "${dir}" -type f -print0)
diff --git a/tests/lint b/tests/lint
index 2f81b8aa..6e68cfb9 100755
--- a/tests/lint
+++ b/tests/lint
@@ -57,6 +57,7 @@ run_shellcheck \
resources/packages/ich9utils/distclean \
resources/packages/memtest86plus/distclean \
resources/packages/payloads/distclean \
+ resources/packages/release/test \
resources/packages/rom_images/distclean \
resources/packages/roms/distclean \
resources/packages/roms/download \
--
2.46.0
- [PATCH v1 01/22] website: status: KCMA-D8: mention missing high resolution graphics images., (continued)
- [PATCH v1 01/22] website: status: KCMA-D8: mention missing high resolution graphics images., Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 05/22] website: status: D945GCLF/D945GCLF2D: mention missing high resolution graphics images., Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 07/22] website: status: GA-G41M-ES2L: mention missing high resolution graphics images., Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 03/22] website: status: KGPE-D16: mention missing high resolution graphics images., Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 08/22] website: status: D945GCLF/D945GCLF2D: mention missing GRUB images., Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 14/22] website: status: KCMA-D8: split status in ECC/non-ECC., Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 16/22] website: status: 0.1 RC5: set KGPE-D16 with GRUB and ECC RAM as tested., Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 15/22] website: status: RC4/RC5: cosmetics: align cell text top-left., Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 11/22] release: tests: whitespace fixes., Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 19/22] website: status: 0.1 RC4: mark Vikings D16 as tested, Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 12/22] release: tests: make it pass shellcheck.,
Denis 'GNUtoo' Carikli <=
- [PATCH v1 17/22] website: global.css: fix titles top and down margins, Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 09/22] website: status: KFSN4-DRE: mention missing GRUB images., Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 13/22] website: status: KGPE-D16: split status in ECC/non-ECC., Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 22/22] website: docs: install: index: add Spanish translation., Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 20/22] website: docs: index: add Spanish translation., Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 18/22] website: status: RC4: mark Asus D16, Lenovo R400 and T500 as tested, Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 10/22] release: tests: add debug images to the list of expected files., Denis 'GNUtoo' Carikli, 2024/12/20
- [PATCH v1 21/22] website: index: add French translation., Denis 'GNUtoo' Carikli, 2024/12/20