Re: [Gnash-commit] Re: key_event_test

[zou lunkai]

> Maybe we need a level for user-triggered
> events being < the our currently lower level (INIT).

But level only works with elements in actions queue.  User defined
event handlers are out of the queue, IIRC.
Emm, seems need more test work.

--zou


On Nov 23, 2007 3:18 PM, strk <address@hidden> wrote:
> On Fri, Nov 23, 2007 at 01:34:36PM +0800, zou lunkai wrote:
> > strk,
> >
> > about the failure in key_event_test.c:
> >
> > found the culprint. It is the  ActionExec::cleanupAfterRun(bool
> > expectInconsistencies). See the following call stack:
> >             ...
> >           movie_root::processActionQueue()
> >         movie_root::flushHigherPriorityActionQueues()
> >       ActionExec::cleanupAfterRun()
> >     ActionExec::operator()()
> >   swf_function::operator()
> > call_method()
> >
> > seems ActionExec::cleanupAfterRun()  does too much as its name
> > suggests.  Why cleanupAfterRun triggers processing the action queue?
> > I guess this is not only specific to key event handlers,  other
> > function calls might have the same problem. eg. call_method() triggers
> > processing actions queue, which is not the expected behaviour.  Can
> > you improve the document of this function?
>
> This was to solve the behaviour you observed of higher priority
> queues being executed at end of functions,
> flushHigherPriorityActionQueues *should* call the processActionQueue
> method taking a "level" argument, once for each level < the level
> currently being executed. Maybe we need a level for user-triggered
> events being < the our currently lower level (INIT).
>
> --strk;
>