Re: [glob2-devel] fixes

[Leo Wandersleb]

What Stéphane said.
If I don't react, post here. I'm a bit flooded with mails and mails that look
like pull requests might go under my radar as I check pull requests for work on
github and I might confuse github and bitbucket. I definitelly want to assist in
any progress on glob2 ;)

On 04.02.2018 08:24, Pinky wrote:
> Got it, thanks a lot.
> 
> 
> * Stéphane Magnenat <address@hidden> [2018-02-04 10:34:45 +0100]:
> 
>> I have not been active recently either, but I think that you have an
>> option to make a "pull request", that is, to let the person who owns the
>> repository you forked that you wish to merge back your changes. This
>> person can then inspect your modifications, comment them or accept them.
>>
>> kind regards,
>>
>> Stéphane
>>
>> On 04. 02. 18 10:26, Pinky wrote:
>>> I suppose there is a need for write permission into the main repository?
>>> I'm new to mercurial and bitbucket, and I relley does not want to screew
>>> anything.
>>>
>>>
>>> * Quinn YQ Teh <address@hidden> [2018-02-04 15:29:13 +1100]:
>>>
>>>> I just realised that's your own repository, and you've just made a commit
>>>> to it. Based on my understanding, that's not how it works. I think it
>>>> works
>>>> like this:
>>>>
>>>> 1. You create a branch in the shared repository before you start your
>>>> work
>>>> 2. You commit your work to your own branch until you're done
>>>> 3. You create a Pull Request to merge your branch back into its parent
>>>> branch
>>>> 4. Someone approves your pull request and it can be merged
>>>> 5. After merging, your changes will appear in the parent branch
>>>>
>>>> The parent branch can be any other branch, usually a develop branch. When
>>>> the develop branch is stable and we want to make a release, we merge the
>>>> develop branch into the master branch, and create the release from the
>>>> master branch.
>>>>
>>>> Please correct me if this project uses a different workflow, as I haven't
>>>> been active here for a long time.
>>>>
>>>> -Quinn
>>>>
>>>> On Sun, Feb 4, 2018 at 3:23 PM, Quinn YQ Teh <address@hidden> wrote:
>>>>
>>>>> I don't see any pull requests in https://bitbucket.org/pinky/
>>>>> glob2/pull-requests/
>>>>>
>>>>> Has someone approved and merged the PR already?
>>>>>
>>>>> On Sat, Feb 3, 2018 at 10:46 PM, Pinky <address@hidden> wrote:
>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> I have made few fixes for glob2 right now available at (1). Is this
>>>>>> correct way
>>>>>> to request request to pull changes?
>>>>>>
>>>>>> With best regards,
>>>>>>    J.  Pinkava
>>>>>>
>>>>>>
>>>>>> (1) https://bitbucket.org/pinky/glob2/commits/all
>>>>>>
>>>>>> _______________________________________________
>>>>>> glob2-devel mailing list
>>>>>> address@hidden
>>>>>> https://lists.nongnu.org/mailman/listinfo/glob2-devel
>>>>>>
>>>>>
>>>>>
>>>
>>>> _______________________________________________
>>>> glob2-devel mailing list
>>>> address@hidden
>>>> https://lists.nongnu.org/mailman/listinfo/glob2-devel
>>>
>>>
>>> _______________________________________________
>>> glob2-devel mailing list
>>> address@hidden
>>> https://lists.nongnu.org/mailman/listinfo/glob2-devel
>>>
>>
>> -- 
>> http://stephane.magnenat.net
>>
>> _______________________________________________
>> glob2-devel mailing list
>> address@hidden
>> https://lists.nongnu.org/mailman/listinfo/glob2-devel
> 
> _______________________________________________
> glob2-devel mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/glob2-devel

signature.asc
Description: OpenPGP digital signature