gcjwebplugin-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gcjwebplugin-devel] Patch: AppletTag refactored


From: Lillian Angel
Subject: [Gcjwebplugin-devel] Patch: AppletTag refactored
Date: Wed, 19 Apr 2006 17:53:14 -0400

I refactored AppletTag into 2 classes: AppletTag and TagParser. This
makes more sense to have one class to do the parsing and another to
include the fields and constructors for specific types of tags. The code
is cleaner, all tests still pass, everything still works. By far, the
code is easier to understand.



2006-04-19  Lillian Angel  <address@hidden>

        * src/gnu/gcjwebplugin/AppletTag.java:
        Removed unused fields.
        (AppletTag): Removed.
        (AppletTag): Removed.
        (AppletTag): Made pkg private. Also, fixed calls to
        parseParams and parseArchives to use TagParser's
        functions.
        (AppletTag): Likewise.
        (AppletTag): Likewise.
        (parseAppletTags): Removed.
        (getLocationToURL): Removed.
        * src/gnu/gcjwebplugin/PluginAppletViewer.java
        (start): Changed call from setTag to setParser.
        * src/gnu/gcjwebplugin/PluginAppletWindow.java:
        Added new TagParser field.
        (setTag): Removed.
        (setParser): New function.
        (setHandle): Fixed to use parser to parse the
        applet tags.
        * src/gnu/gcjwebplugin/StandaloneAppletViewer.java
        (StandaloneAppletViewer): Fixed to use TagParser
        instead of AppletTag.
        * src/gnu/gcjwebplugin/TagParser.java: New class.
        Includes parsing fields/functions/constructors which used
        to reside in AppletTag.

Attachment: gcjapp_patch.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]