Re: PATCH: add dejagnu(1) multi-launcher

[Andreas Schwab]

On Dez 19 2018, Jacob Bachmeyer <address@hidden> wrote:

> Andreas Schwab wrote:
>> On Dez 18 2018, Jacob Bachmeyer <address@hidden> wrote:
>>   
>>> Andreas Schwab wrote:
>>>     
>>>> On Dez 18 2018, Jacob Bachmeyer <address@hidden> wrote:
>>>>         
>>>>> +if expr "$verbose" \> 0 > /dev/null ; then
>>>>>             
>>>> Why not test $verbose -gt 0?
>>>>         
>>> The existing "runtest" script uses expr for those tests.  I decided to
>>> follow suit on the assumption that that choice was made for a reason,
>>> presumably portability, although the Autoconf portable shell guidelines do
>>> not mention that concern with "test".
>>>     
>>
>> Your script is already using $( ) and $(( )) which isn't supported by
>> some pre-POSIX shells.
>>   
>
> As does the "runtest" script.  The "dejagnu" script is simply following
> suit.

One more reason to use POSIX as the base.

Andreas.

-- 
Andreas Schwab, SUSE Labs, address@hidden
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."