commit-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[hurd] 39/75: fix compiler warnings in hurd/console-client


From: Samuel Thibault
Subject: [hurd] 39/75: fix compiler warnings in hurd/console-client
Date: Thu, 14 Jan 2016 01:04:08 +0000

This is an automated email from the git hooks/post-receive script.

sthibault pushed a commit to branch dde
in repository hurd.

commit 2280227bedf69b733a589f12ac6b6d5a4fc36af4
Author: Flavio Cruz <address@hidden>
Date:   Tue Dec 29 21:17:25 2015 +0100

    fix compiler warnings in hurd/console-client
    
    On Tue, Dec 29, 2015 at 08:43:24PM +0100, Samuel Thibault wrote:
    > Flavio Cruz, on Tue 29 Dec 2015 17:35:00 +0100, wrote:
    > > @@ -663,10 +663,11 @@ update_leds (void)
    > >         | (led_state.num_lock ? 2 : 0)
    > >         | (led_state.caps_lock ? 4 : 0);
    > >
    > > -      err = device_write_inband (kbd_dev, 0, -1, (void *) leds, 2, 
&data_cnt);
    > > +      err = device_write_inband (kbd_dev, 0, -1, (void *) leds, 2,
    > > +                                 (int *) &data_cnt);
    > >        if (!err && data_cnt == 1)
    > >         err = device_write_inband (kbd_dev, 0, -1, (void *) &leds[1], 1,
    > > -                                  &data_cnt);
    > > +                                  (int *) &data_cnt);
    > >      }
    > >  }
    > >
    >
    > I'm surprised: if the device_write_inband RPC really wants an int*, why
    > not making data_cnt an int?
    
    That works better. Thanks.
    
    console-client: Fix compiler warning.
    
    * console-client/pc-kbd.c (update_leds): Replace mach_msg_type_number_t with
    int.
---
 console-client/pc-kbd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/console-client/pc-kbd.c b/console-client/pc-kbd.c
index 6f2d827..2fc7608 100644
--- a/console-client/pc-kbd.c
+++ b/console-client/pc-kbd.c
@@ -656,7 +656,7 @@ update_leds (void)
   else
     {
       char leds[2];
-      mach_msg_type_number_t data_cnt = 2;
+      int data_cnt = 2;
 
       leds[0] = '\xed';
       leds[1] = (led_state.scroll_lock ? 1 : 0)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/pkg-hurd/hurd.git



reply via email to

[Prev in Thread] Current Thread [Next in Thread]