[hurd] 05/26: commit 0c27922e4933ceb86644f4a9b1af212ffe5aad75

[Samuel Thibault]

This is an automated email from the git hooks/post-receive script.

sthibault pushed a commit to branch dde
in repository hurd.

commit d22caacba224d7c04eb586105e822b5ad3a1c9b8
Author: Eric Dumazet <address@hidden>
Date:   Mon Jun 8 03:49:24 2009 +0000

    commit 0c27922e4933ceb86644f4a9b1af212ffe5aad75
    
        net: dev_addr_init() fix
    
        commit f001fde5eadd915f4858d22ed70d7040f48767cf
        (net: introduce a list of device addresses dev_addr_list (v6))
        added one regression Vegard Nossum found in its testings.
    
        With kmemcheck help, Vegard found some uninitialized memory
        was read and reported to user, potentialy leaking kernel data.
        ( thread can be found on http://lkml.org/lkml/2009/5/30/177 )
    
        dev_addr_init() incorrectly uses sizeof() operator. We were
        initializing one byte instead of MAX_ADDR_LEN bytes.
    
        Reported-by: Vegard Nossum <address@hidden>
        Signed-off-by: Eric Dumazet <address@hidden>
        Acked-by: Jiri Pirko <address@hidden>
        Signed-off-by: David S. Miller <address@hidden>
---
 libdde_linux26/lib/src/net/core/dev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libdde_linux26/lib/src/net/core/dev.c 
b/libdde_linux26/lib/src/net/core/dev.c
index 958345b..f01d355 100644
--- a/libdde_linux26/lib/src/net/core/dev.c
+++ b/libdde_linux26/lib/src/net/core/dev.c
@@ -3577,8 +3577,8 @@ static int dev_addr_init(struct net_device *dev)
        /* rtnl_mutex must be held here */
 
        INIT_LIST_HEAD(&dev->dev_addr_list);
-       memset(addr, 0, sizeof(*addr));
-       err = __hw_addr_add(&dev->dev_addr_list, NULL, addr, sizeof(*addr),
+       memset(addr, 0, sizeof(addr));
+       err = __hw_addr_add(&dev->dev_addr_list, NULL, addr, sizeof(addr),
                            NETDEV_HW_ADDR_T_LAN);
        if (!err) {
                /*

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/pkg-hurd/hurd.git