RE: java.util.zip.InflaterInputStream patch

[Mark Wielaard]

Hi,

On Fri, 2002-10-25 at 04:45, Wu, Gansha wrote:
>      You're right. GNU Classpath's java.util.zip doesn't need the padding 
> because it doesn't use zlib, but a patch there doesn't change the
> correctness 
> of GNU Classpath's pure Java java.util.zip implementation. ORP has another 
> java.util.zip implementation which implements some critical methods by JNI 
> native methods, and as such improves the performance of some real-world 
> business applications significantly. This alternative implementation is
> using 
> zlib and so needs the patch. 
>
>      BTW, ORP's zlib implementation is turned off in current ORP release,
> and 
> can be turned on by USE_NATIVE_ZIP_LIB with some changes to 
> java.util.zip.ZipFile/Inflator/ZipEntry which are not in our submission.

Then I think it would be best to work around this bug in this JNI code
just like the libgcj version does. I don't like having workarounds in
our code for bugs in code that is not part of GNU Classpath. Unless one
of the jazzlib hackers says that this workaround is indeed not confusing
and obviously the correct way to go. It did confuse me though :)

Cheers,

Mark