chicken-janitors
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: #1686: egg install scripts don't have to rm before install


From: Chicken Trac
Subject: Re: #1686: egg install scripts don't have to rm before install
Date: Mon, 09 Mar 2020 20:08:31 -0000

#1686: egg install scripts don't have to rm before install
-------------------------------------+-------------------------------------
            Reporter:  Mario         |      Owner:  (none)
  Domenech Goulart                   |
                Type:  enhancement   |     Status:  new
            Priority:  not urgent    |  Milestone:  5.3
  at all                             |
           Component:  core          |    Version:  5.2.0
  libraries                          |   Keywords:  install, rm, chicken-
          Resolution:                |  install
Estimated difficulty:                |
-------------------------------------+-------------------------------------

Comment (by Mario Domenech Goulart):

 Maybe something like the following patch would improve things (only
 quickly tested with a single egg).

 {{{
 diff --git a/egg-compile.scm b/egg-compile.scm
 index 4a72d5d0..f6de778c 100644
 --- a/egg-compile.scm
 +++ b/egg-compile.scm
 @@ -940,7 +940,6 @@
                                      output-file)
           srcdir platform)
    (let* ((cmd (install-executable-command platform))
 -         (dcmd (remove-file-command platform))
           (mkdir (mkdir-command platform))
           (sname (prefix srcdir name))
           (out (qs* (target-file (conc sname ext) mode) platform #t))
 @@ -949,8 +948,6 @@
           (ddir (shell-variable "DESTDIR" platform))
           (destf (qs* (conc dest "/" output-file ext) platform #t)))
      (print "\n" mkdir " " ddir dfile)
 -    (when (eq? platform 'unix)
 -      (print dcmd " " ddir destf))
      (print cmd " " out " " ddir destf)
      (print-end-command platform)))

 @@ -1005,7 +1002,6 @@

  (define ((install-program name #!key mode output-file) srcdir platform)
    (let* ((cmd (install-executable-command platform))
 -         (dcmd (remove-file-command platform))
           (mkdir (mkdir-command platform))
           (ext (executable-extension platform))
           (sname (prefix srcdir name))
 @@ -1017,8 +1013,6 @@
           (ddir (shell-variable "DESTDIR" platform))
           (destf (qs* (conc dest "/" output-file ext) platform #t)))
      (print "\n" mkdir " " ddir dfile)
 -    (when (eq? platform 'unix)
 -      (print dcmd " " ddir destf))
      (print cmd " " out " " ddir destf)
      (print-end-command platform)))

 }}}

-- 
Ticket URL: <https://bugs.call-cc.org/ticket/1686#comment:1>
CHICKEN Scheme <https://www.call-cc.org/>
CHICKEN Scheme is a compiler for the Scheme programming language.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]