Re: [bug-patch] [PATCH] remove side effect from assert

[Andreas Gruenbacher]

On Tuesday 24 May 2011 15:42:49 Jim Meyering wrote:
> While looking at the nearby expression (suspicious-but-ok,
> highlighted by coverity as matching the form malloc(strlen(...)),
> 
>   u = v = xmalloc (strlen (s));
> 
> I saw that the preceding assert statement had a side effect:
> 
>     assert (*s++ == '"');
> 
> That means disabling assertions would have impacted correctness.
> Here's the fix:

Good catch.

Thanks,
Andreas