[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #60188] Explicit file built by an implicit rule is not intermediate
From: |
Paul D. Smith |
Subject: |
[bug #60188] Explicit file built by an implicit rule is not intermediate. |
Date: |
Mon, 15 Mar 2021 02:23:35 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.90 Safari/537.36 |
Update of bug #60188 (project make):
Status: None => Fixed
Open/Closed: Open => Closed
Component Version: SCM => 4.3
Operating System: None => Any
Fixed Release: None => SCM
Triage Status: None => Medium Effort
_______________________________________________________
Follow-up Comment #3:
Thanks for those changes Dmitry. I applied them mostly as-is.
Especially thanks for the tests! For the future a few notes about tests:
1) Unless you're trying to test the built-in rules, it's best to not use any
of them in the tests and instead define your own. The problem is that the
output of the built-in rules might be different on different platforms (for
example the default compiler might be named something different) then the
tests will fail.
2) I prefer to avoid adding TAB characters into my test rules unless they are
really required, and instead use the ";" separator to put the entire rule one
one line. Otherwise, it's easy for editors which convert TAB to space in Perl
code (which is common) to corrupt the test files when they're edited.
3) The tests available represent a significant evolution over time so the
older tests and older test methods should be avoided; someday all the tests
should be rewritten to use the modern syntax but in any event we should avoid
adding more old-style tests even to test files that haven't been updated yet
(the tests you provided here are all new-style so that's good, just FYI).
Cheers!
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?60188>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [bug #60188] Explicit file built by an implicit rule is not intermediate., Dmitry Goncharov, 2021/03/07
- [bug #60188] Explicit file built by an implicit rule is not intermediate., Dmitry Goncharov, 2021/03/07
- [bug #60188] Explicit file built by an implicit rule is not intermediate., Dmitry Goncharov, 2021/03/07
- [bug #60188] Explicit file built by an implicit rule is not intermediate., Dmitry Goncharov, 2021/03/07
- [bug #60188] Explicit file built by an implicit rule is not intermediate., Dmitry Goncharov, 2021/03/07
- [bug #60188] Explicit file built by an implicit rule is not intermediate., Dmitry Goncharov, 2021/03/07
- [bug #60188] Explicit file built by an implicit rule is not intermediate., Dmitry Goncharov, 2021/03/07
- [bug #60188] Explicit file built by an implicit rule is not intermediate., Dmitry Goncharov, 2021/03/07
- [bug #60188] Explicit file built by an implicit rule is not intermediate., Paul D. Smith, 2021/03/08
- [bug #60188] Explicit file built by an implicit rule is not intermediate.,
Paul D. Smith <=
- [bug #60188] Explicit file built by an implicit rule is not intermediate., Dmitry Goncharov, 2021/03/20
- [bug #60188] Explicit file built by an implicit rule is not intermediate., Dmitry Goncharov, 2021/03/20
- [bug #60188] Explicit file built by an implicit rule is not intermediate., Dmitry Goncharov, 2021/03/20
- [bug #60188] Explicit file built by an implicit rule is not intermediate., Paul D. Smith, 2021/03/21