[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] * src/function.c: Introduce the 'let' built-in function
From: |
Paul Smith |
Subject: |
Re: [PATCH 1/2] * src/function.c: Introduce the 'let' built-in function |
Date: |
Fri, 23 Oct 2020 09:14:37 -0400 |
User-agent: |
Evolution 3.36.4-0ubuntu1 |
On Fri, 2020-10-09 at 16:36 +0200, Jouke Witteveen wrote:
> This was sent before at the end of last year. Meanwhile, the
> copyright of my contributions is assigned to the FSF, so I picked
> this up again and added some documentation (next patch).
Sorry for the delay. I have been super-busy (you'd think working from
home would give one _more_ time but it seems not).
Thanks for the docs! Very helpful.
The thing most critically missing is a set of regression tests we can
use to ensure that the feature is working (including various corner
cases you would like to ensure), so that we can be sure it _keeps_
working. Also I run these tests under valgrind and ASAN and similar to
check for memory leaks and other errors.
If you need some pointers on writing tests (it's not always so simple
and the test suite has evolved and changed over time, with older tests
not being rewritten to the new format) let me know.