[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
patch, test suite fails to run valgrind
From: |
Dmitry Goncharov |
Subject: |
patch, test suite fails to run valgrind |
Date: |
Wed, 18 Sep 2019 21:38:49 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Good morning.
The test suite fails to run valgrind with an error message like the following.
$ ./run_make_tests -memcheck -make_path ../l64/make
features/archives ....................................... ok (12 passed)
features/comments .......................................
*** Test died (features/comments): Command failed: exec: Cannot execute
valgrind --log-fd=4 --num-callers=15 --tool=memcheck --leak-check=full
--suppressions=guile.supp /home/dgoncharov/src/gmake/make/tests/../l64/make
This happens because _run_with_timeout attempts to exec an array, while exec
expects a list.
regards, Dmitry
diff --git a/tests/test_driver.pl b/tests/test_driver.pl
index 1bb98ba..511a43f 100644
--- a/tests/test_driver.pl
+++ b/tests/test_driver.pl
@@ -1008,7 +1008,7 @@ sub _run_with_timeout
} else {
my $pid = fork();
if (! $pid) {
- exec(@_) or die "exec: Cannot execute $_[0]\n";
+ exec("@_") or die "exec: Cannot execute $_[0]: $!\n";
}
local $SIG{ALRM} = sub {
my $e = $ERRSTACK[0];
- patch, test suite fails to run valgrind,
Dmitry Goncharov <=