bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: vpathplus test 2 patch


From: Paul Smith
Subject: Re: vpathplus test 2 patch
Date: Mon, 16 Sep 2019 08:52:39 -0400
User-agent: Evolution 3.32.1-2

On Thu, 2019-09-12 at 09:33 +0200, Andreas Schwab wrote:
> On Sep 11 2019, Dmitry Goncharov <address@hidden> wrote:
> > On Wed, Sep 11, 2019 at 2:51 AM Andreas Schwab <address@hidden> wrote:
> > > > The new hashing mechanism hashes differently on big vs little
> > > > endian.
> > > 
> > > Should this be considered as a bug?
> > 
> > I don't think the order or removal of intermediate files was
> > specified.
> 
> The testsuite obviously is depending on it.

The test suite simply matches output strings, it's not very intelligent
about stuff like that (unfortunately).

I didn't apply this change because I'm not exactly sure where I want to
go with this yet.  I'm not excited about tweaking the test suite based
on the endianness of the underlying system but it seems silly to reduce
the performance of the hash to make it consistent across endianness as
well.

Will fix this before 4.3 is released though.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]