[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: patch to fix grouped_targets test 1
|
From: |
Paul Smith |
|
Subject: |
Re: patch to fix grouped_targets test 1 |
|
Date: |
Sat, 14 Sep 2019 13:05:24 -0400 |
|
User-agent: |
Evolution 3.32.1-2 |
On Tue, 2019-09-10 at 20:36 -0400, Dmitry Goncharov via Bug reports and
discussion for GNU make wrote:
> echo -n is not portable.
> Certain implementations of echo everything, including -n.
> This makes test 1 of grouped_targets fail.
This was already fixed by a patch from Paul Eggert on Aug 27.
Thanks!
commit 8bffc8d53ce302f3170b10c70f3a9680a6b72b68
Author: Paul Eggert <address@hidden>
Date: 2019-08-27 01:08:47 -0700
Port grouped_targets test to Solaris 10
* tests/scripts/features/grouped_targets: Use ‘printf ''’
instead of ‘echo -n’, as POSIX says the latter is not portable.
diff --git a/tests/scripts/features/grouped_targets
b/tests/scripts/features/grouped_targets
index ef9366b..615e962 100644
--- a/tests/scripts/features/grouped_targets
+++ b/tests/scripts/features/grouped_targets
@@ -9,7 +9,7 @@ $details = "Here we test for requirements like\n"
run_make_test(q{
.PHONY: all
&:;
-all: ;@echo -n
+all: ;@printf ''
},
'', "");