[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: patch out of source builds
From: |
Dmitry Goncharov |
Subject: |
Re: patch out of source builds |
Date: |
Sat, 14 Sep 2019 09:39:22 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, Sep 14, 2019 at 10:19:56AM +0300, Eli Zaretskii wrote:
> > This patch makes the test suite look for config.status in the -make_path
> > directory to allow testing out of source builds.
>
> Thanks, but I don't think relying on config_status is good enough,
> because some builds don't have it. For example, what happens when
> Make is built using build.sh? And on MS-Windows the _only_ supported
> build method is by using a script similar to build.sh.
run_make_tests.pl unconditionally reads config.status from a specific location.
If gmake is built out of source this reading fails. The patch then looks for
config.status in the -make_path directory. This will help if you have
config.status in the -make_path directory. If you don't have config.status in
-make_path directory this won't help and won't hurt. If you don't have
config.status in -make_path directory it will behave the same as today.
regards, Dmitry