[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: patch to fix features/archives test 10 on sunos
From: |
Eli Zaretskii |
Subject: |
Re: patch to fix features/archives test 10 on sunos |
Date: |
Tue, 10 Sep 2019 19:17:25 +0300 |
> From: Paul Smith <address@hidden>
> Cc: address@hidden, address@hidden
> Date: Tue, 10 Sep 2019 11:47:35 -0400
>
> On Tue, 2019-09-10 at 17:47 +0300, Eli Zaretskii wrote:
> > > From: Paul Smith <address@hidden>
> > > Date: Tue, 10 Sep 2019 08:36:24 -0400
> > >
> > > I plan to make a new release candidate this week.
> >
> > Did you have a chance to review the patch I proposed in
> > https://lists.gnu.org/archive/html/bug-make/2019-08/msg00106.html?
> > I'd like to install it.
>
> Oh I already made that change... plus in another place that did similar
> things. Sorry I should have added a note about it.
OK, thanks. No harm done.
> > Also, regarding SV 56449: are you okay with reverting that change,
> > given the discussion and OP's agreement with me?
>
> Yes, that's fine.
Done.
> I do think there's some uncleanliness about this. It's upsetting that
> Windows behaves so differently between the command line and batch file.
> It makes it very difficult to implement any sort of batch mode
> fallback. Oh well.
Agreed.
Btw, I see you added support for dirent.d_type for dirent functions
emulation when compiling with MSVC, but I don't think Make uses this
anywhere, except when building with glibc. In particular, the
HAVE_STRUCT_DIRENT_D_TYPE macro doesn't seem to be referenced
anywhere. Did I miss something?