Re: Latest CVS make compile warnings fix

[Paul D. Smith]

%% "J. Grant" <address@hidden> writes:

  jg> If I submit fixes for these would they be reviewed for inclusion ?

I'm happy to look at them, but they will not be easy to fix.

  jg> main.c:420: warning: missing initializer
  jg> main.c:420: warning: (near initialization for `switches[30].type')

This one, IMO, could be a bug in GCC.  As far as I can tell the
initializer is correct.  The only way to avoid the warning seems to be
to put a full suite of 0 initializations into the last element.  But
that shouldn't be necessary, if I remember my ISO standard properly.

  jg> main.c: In function `main':
  jg> main.c:1790: warning: comparison of unsigned expression < 0 is always 
false
  jg> main.c:2122: warning: comparison of unsigned expression < 0 is always 
false

  jg> remake.c: In function `update_file_1':
  jg> remake.c:432: warning: comparison of unsigned expression < 0 is always 
false
  jg> remake.c: In function `notice_finished_file':
  jg> remake.c:863: warning: comparison of unsigned expression < 0 is always 
fals

  jg> file.c: In function `file_timestamp_cons':
  jg> file.c:679: warning: comparison of unsigned expression < 0 is always false
  jg> file.c:680: warning: comparison between signed and unsigned
  jg> file.c:680: warning: comparison of unsigned expression < 0 is always false
  jg> file.c:683: warning: comparison of unsigned expression < 0 is always false

All of these are not going to be easy to fix.  The code is actually
created that way for a reason, IIRC.

  jg> job.c: In function `start_job_command':
  jg> job.c:944: warning: variable `flags' might be clobbered by `longjmp' or 
  jg> `vfork'
  jg> job.c:948: warning: variable `argv' might be clobbered by `longjmp' or 
  jg> `vfork'
  jg> job.c: In function `construct_command_argv_internal':

Hm.  I think this has already been resolved: are you looking at the
beta3 code??  I don't get this warning anymore in my version.


I _think_ that was because of some very questionable (stylistically
speaking: the code did work and was valid) use of goto, that I actually
removed when I rewrote the backslash-newline handling to comply with
POSIX.

-- 
-------------------------------------------------------------------------------
 Paul D. Smith <address@hidden>          Find some GNU make tips at:
 http://www.gnu.org                      http://make.paulandlesley.org
 "Please remain calm...I may be mad, but I am a professional." --Mad Scientist