Re: m4-1.4.19 not C99 clean ?

[Dennis Clarke]

On 9/13/21 14:38, Paul Eggert wrote:
> On 9/13/21 7:11 AM, Eric Blake wrote:
> 
>> I'm not sure how much of gnulib still tries to cater to C89,
>> vs. assuming C99.
> 
> Gnulib no longer bothers with porting back to C89. However, this issue
> is due to a C99 compiler being pedantic, so we should fix it. I
> installed the attached into Gnulib on Savannah; please give it a try.
> With this patch, on my Solaris 10 sparc platform, Oracle Developer
> Studio 12.6 c99 issues a warning but it is not fatal, and that should be
> good enough.

This seems to work well :

--- ./lib/asyncsafe-spin.c.orig Thu Apr  1 20:30:11 2021
+++ ./lib/asyncsafe-spin.c      Wed Sep 15 06:07:43 2021
@@ -27,6 +27,10 @@
 # include <sys/atomic_op.h>
 #endif

+#if 0x590 <= __SUNPRO_C && __STDC__
+# define asm __asm
+#endif
+
 #if defined _WIN32 && ! defined __CYGWIN__
 /* Use Windows threads.  */


Compile looks great and I did not see a warning fly by. I may need to
look at the logs more closely.  I do see a test failure :


.
.
.
Checking ./197.sysval
Checking ./198.sysval
@ ../doc/m4.texi:6751: Origin of test
./198.sysval: stderr mismatch
--- m4-tmp.13845/m4-xerr        Wed Sep 15 06:23:08 2021
+++ m4-tmp.13845/m4-err Wed Sep 15 06:23:08 2021
@@ -1,0 +1,1 @@
+sh: 16015 Killed
Checking ./199.mkstemp
Checking ./200.mkstemp
.
.
.
Checking ./236.improved_f
Checking ./stackovf.test
Stack soft limit set to 300K
Pass

Skipped checks were:
  ./125.changeword ./126.changeword ./127.changeword ./128.changeword
./129.changeword ./130.changeword
Failed checks were:
  ./198.sysval:err
gmake[3]: *** [Makefile:2065: check-local] Error 1
gmake[3]: Leaving directory
'/opt/bw/build/m4-1.4.19_sunos5.10_sparcv9.003/checks'
gmake[2]: *** [Makefile:1941: check-am] Error 2
gmake[2]: Leaving directory
'/opt/bw/build/m4-1.4.19_sunos5.10_sparcv9.003/checks'
gmake[1]: *** [Makefile:2018: check-recursive] Error 1
gmake[1]: Leaving directory '/opt/bw/build/m4-1.4.19_sunos5.10_sparcv9.003'
gmake: *** [Makefile:2317: check] Error 2



Seems related to :

    https://lists.gnu.org/archive/html/bug-m4/2021-06/msg00009.html

I may also need to get in there and patch that doc/m4.texi file.


-- 
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
GreyBeard and suspenders optional