[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30820: Chunked store references in compiled code break grafting (aga
From: |
Danny Milosavljevic |
Subject: |
bug#30820: Chunked store references in compiled code break grafting (again) |
Date: |
Mon, 19 Mar 2018 22:22:05 +0100 |
Hi Ludo,
> The second issue is that the patch only ever worked with literal
> strings. It does not “see” strings in constant arrays like the ‘str’
> array in the example above.
>
> The gconv-module file name mentioned in the first message in this bug
> report is an example of a string assigned to a static array, in
> iconv/gconv_conf.c:
>
> /* This is the default path where we look for module lists. */
> static const char default_gconv_path[] = GCONV_PATH;
I don't understand why this is a problem. Grafting would just
mutate default_gconv_path, right? Who cares how the runtime memcpy
works (if there's no literal as source)?
Or do you mean that it memcpys at compile time?
pgpZfjRDtrJDo.pgp
Description: OpenPGP digital signature
bug#30820: Chunked store references in compiled code break grafting (again), Mark H Weaver, 2018/03/19
bug#30820: Chunked store references in compiled code break grafting (again), Ludovic Courtès, 2018/03/19