[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#22050: [PATCH v5 2/2] services: base: Use make-static-device-nodes.
From: |
Ludovic Courtès |
Subject: |
bug#22050: [PATCH v5 2/2] services: base: Use make-static-device-nodes. |
Date: |
Fri, 15 Dec 2017 10:44:22 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Danny Milosavljevic <address@hidden> skribis:
> * gnu/services/base.scm (udev-shepherd-service): Use make-static-device-nodes.
> ---
> gnu/services/base.scm | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/services/base.scm b/gnu/services/base.scm
> index 291dd6325..34699cdcd 100644
> --- a/gnu/services/base.scm
> +++ b/gnu/services/base.scm
> @@ -1727,6 +1727,14 @@ item of @var{packages}."
> (setenv "EUDEV_RULES_DIRECTORY"
> #$(file-append rules "/lib/udev/rules.d"))
>
> + (let* ((kernel-release
> + (utsname:release (uname)))
^
Indentation.
> + (linux-module-directory
> + (getenv "LINUX_MODULE_DIRECTORY"))
> + (linux-release-module-directory
> + (string-append linux-module-directory "/"
> + kernel-release)))
> + (make-static-device-nodes
> linux-release-module-directory))
Nitpick: I think ‘directory’ would be good enough as an identifier to
this local variable.
Otherwise LGTM!
- bug#22050: [PATCH v3 1/2] linux-boot: Add make-static-device-nodes., (continued)
bug#22050: [PATCH v4 0/2] Create static device nodes before starting udev., Danny Milosavljevic, 2017/12/14
- bug#22050: [PATCH v4 2/2] services: base: Use make-static-device-nodes., Danny Milosavljevic, 2017/12/14
- bug#22050: [PATCH v4 1/2] linux-boot: Add make-static-device-nodes., Danny Milosavljevic, 2017/12/14
- bug#22050: [PATCH v4 1/2] linux-boot: Add make-static-device-nodes., Ludovic Courtès, 2017/12/15
- bug#22050: [PATCH v4 1/2] linux-boot: Add make-static-device-nodes., Danny Milosavljevic, 2017/12/15
- bug#22050: [PATCH v4 1/2] linux-boot: Add make-static-device-nodes., Ludovic Courtès, 2017/12/15
bug#22050: [PATCH v5 0/2] Create static device nodes before starting udev., Danny Milosavljevic, 2017/12/14
bug#22050: [PATCH v5 2/2] services: base: Use make-static-device-nodes., Danny Milosavljevic, 2017/12/14
bug#22050: [PATCH v5 2/2] services: base: Use make-static-device-nodes.,
Ludovic Courtès <=
bug#22050: [PATCH v5 1/2] linux-boot: Add make-static-device-nodes., Danny Milosavljevic, 2017/12/14