bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] stdlib: fix MB_CUR_MAX on older Android


From: Bruno Haible
Subject: Re: [PATCH 2/2] stdlib: fix MB_CUR_MAX on older Android
Date: Wed, 25 Dec 2024 15:17:26 +0100

Paul Eggert wrote:
> +    [AC_LINK_IFELSE(
> +     [AC_LANG_PROGRAM([[#include <stdlib.h>
> +                      ]],
> +                      [[return !!MB_CUR_MAX;]])],
> +     [dnl Initial guess, used when cross-compiling or when no suitable locale

With only 1 column of indentation, I have a hard time understanding the
structure of this code. Need to indent it better, for readability:


2024-12-25  Bruno Haible  <bruno@clisp.org>

        stdlib: Improve change from 2024-12-23.
        * m4/stdlib_h.m4 (gl_STDLIB_H): Improve indentation.

diff --git a/m4/stdlib_h.m4 b/m4/stdlib_h.m4
index f1192e3d25..ba56a9480b 100644
--- a/m4/stdlib_h.m4
+++ b/m4/stdlib_h.m4
@@ -1,5 +1,5 @@
 # stdlib_h.m4
-# serial 83
+# serial 84
 dnl Copyright (C) 2007-2024 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -42,19 +42,20 @@ AC_DEFUN_ONCE([gl_STDLIB_H]
   AC_CACHE_CHECK([whether MB_CUR_MAX is correct],
     [gl_cv_macro_MB_CUR_MAX_good],
     [AC_LINK_IFELSE(
-     [AC_LANG_PROGRAM([[#include <stdlib.h>
-                      ]],
-                      [[return !!MB_CUR_MAX;]])],
-     [dnl Initial guess, used when cross-compiling or when no suitable locale
-      dnl is present.
-      # Guess no on Solaris and Haiku, yes otherwise.
-      AS_CASE([$host_os],
-        [solaris* | haiku*],
-          [gl_cv_macro_MB_CUR_MAX_good="guessing no"],
-          [gl_cv_macro_MB_CUR_MAX_good="guessing yes"])
-      if test "$LOCALE_EN_UTF8" != none; then
-        AC_RUN_IFELSE(
-          [AC_LANG_SOURCE([[
+       [AC_LANG_PROGRAM([[#include <stdlib.h>
+                        ]],
+                        [[return !!MB_CUR_MAX;]])
+       ],
+       [dnl Initial guess, used when cross-compiling or when no suitable locale
+        dnl is present.
+        # Guess no on Solaris and Haiku, yes otherwise.
+        AS_CASE([$host_os],
+          [solaris* | haiku*],
+            [gl_cv_macro_MB_CUR_MAX_good="guessing no"],
+            [gl_cv_macro_MB_CUR_MAX_good="guessing yes"])
+        if test "$LOCALE_EN_UTF8" != none; then
+          AC_RUN_IFELSE(
+            [AC_LANG_SOURCE([[
 #include <locale.h>
 #include <stdlib.h>
 int main ()
@@ -67,12 +68,12 @@ AC_DEFUN_ONCE([gl_STDLIB_H]
     }
   return result;
 }]])],
-          [gl_cv_macro_MB_CUR_MAX_good=yes],
-          [gl_cv_macro_MB_CUR_MAX_good=no],
-          [:])
-      fi
-     ],
-     [gl_cv_macro_MB_CUR_MAX_good="link failed - so no"])
+            [gl_cv_macro_MB_CUR_MAX_good=yes],
+            [gl_cv_macro_MB_CUR_MAX_good=no],
+            [:])
+        fi
+       ],
+       [gl_cv_macro_MB_CUR_MAX_good="link failed - so no"])
     ])
   AS_CASE([$gl_cv_macro_MB_CUR_MAX_good],
     [*yes],






reply via email to

[Prev in Thread] Current Thread [Next in Thread]