Re: [PATCH] crc: Add PCLMUL implementation

[Sam Russell]

Hi guys,

Just bumping this, is this a change we would like to include? Are there any issues with the patch that you'd like me to fix?

Cheers

Sam

On Tue, Nov 26, 2024, 23:01 Sam Russell <sam.h.russell@gmail.com> wrote:

> It's your choice: 3 compilation units for x86_64, or 1 compilation unit
> for x86_64, or no extra compilation unit (all code contained in .h files) —
> as you prefer. Fine with me either way.

Let's cross that bridge when we get to it :) I'm fairly relaxed which one we choose in the end.

Final patch for now with alignment removed based on Jeff's feedback that _mm_loadu_si128() accepts unaligned data. bench-crc, test-crc and gzip all happy.

Am I correct in thinking that we are just waiting for Simon's input now?

On Tue, 26 Nov 2024 at 22:53, Bruno Haible <bruno@clisp.org> wrote:

Sam Russell wrote:
> It makes sense to keep them in the same module though, I agree.

Thanks.

> I'd prefer to keep them as separate files if you're okay with it. I did a
> quick experiment and by wrapping each function in push_options and
> pop_options pragmas it was pretty easy to get it all working in the same
> file so I can confirm that option does work.

It's your choice: 3 compilation units for x86_64, or 1 compilation unit
for x86_64, or no extra compilation unit (all code contained in .h files) —
as you prefer. Fine with me either way.

Bruno