bug#74775: [PATCH] Update browse-url-kde variables

[Björn Bidar]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Wed, 11 Dec 2024 01:04:56 +0200
>> From:  Björn Bidar via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>> 
>> Update browse-url-kde's variables.
>
> Thanks, but when we change the default value of a user option, we need
> to update its :version tag (so that commands like customize-changed
> could notice that).

Will do good call.

>> -(defcustom browse-url-kde-program "kfmclient"
>> +(defcustom browse-url-kde-program "kde-open"
>>    "The name by which to invoke the KDE web browser."
>
> Should we offer the other name as a (non-default) alternative?  It is
> still available, right?

The other one is still available but kde-open is then installed at the
same time too. Both to the same thing it doesn't make sense to still
offer kfmclient here.

>>    :type 'string
>
> Should this be 'file instead?

Does 'file for programs in path?

>> -(defcustom browse-url-kde-args '("openURL")
>> +(defcustom browse-url-kde-args nil
>>    "A list of strings defining options for `browse-url-kde-program'."
>
> Should the default value depend on the value of
> browse-url-kde-program?  E.g., if that is customized to kfmclient, the
> value of this variable should probably not be '("openURL"), right?

For kfmclient it should be '("openURL") for others not.

I think it would make sense to apply this change to Emacs 30 too as it
isn't a functionality change but a fix to not use kfmclient which is not
installed anymore these days as the default file manager for KDE is
Dolphin and not Konqueror which includes kfmclient.