bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] split: --chunks option


From: Pádraig Brady
Subject: Re: [PATCH] split: --chunks option
Date: Sun, 10 Jan 2010 00:38:23 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0

On 10/01/10 00:09, Chen Guo wrote:
Hi Padraig,

     I went ahead and corrected the errors you caught, as well as
moved over eol_parse() to gl/lib/unescape.c. Calls from ptx, pr,
and printf, as you said, probably should be in a separate patch.

     Also I noticed gl/lib/randperm.h didn't have the GPL
disclaimer thing at the beginning. I though it might've been b/c
of the small size, but mbsalign.h also had it, so I went ahead
and added the disclaimer. I'm guessing this is also by Prof.
Eggert, but it seems convention is to only declare authorship
in the .c files, so I left that out.

Thanks for the update Chen.
I'll review this hopefully early next week.

cheers,
Pádraig.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]