Re: new snapshot [Re: coreutils 6.9.92 fail to configure on *bsd

[Jim Meyering]

Elias Pipping <address@hidden> wrote:
...
> D'oh -- should've read that. So, with 6.10 and --disable-acl,
> all of the non-root tests pass and a single root-only test fails:
>
>     % tar xf coreutils-6.10.tar.gz
>     % cd coreutils-6.10
>     % ./configure --disable-acl
>     % make -j3
>     % sudo env VERBOSE=yes NON_ROOT_USERNAME=$USER make check -C tests/cp 
> TESTS=preserve-gid
>     make  check-TESTS
>     FAIL: preserve-gid.log
...
>     ++ stat -c '%u %g' b
>     + s='0 20'
>     + test 'x0 20' '!=' 'x0 0'
>     + echo './preserve-gid: cp a0 b: 0 0 != 0 20'

Thanks for the report and details.
That's probably due to your running the root-only
tests in a directory with the sticky set-GID bit set.

If that's the problem, here's an untested fix:

        * tests/cp/preserve-gid: Skip this test when run in a setgid directory.
        Reported by Elias Pipping.

diff --git a/tests/cp/preserve-gid b/tests/cp/preserve-gid
index 5f2c050..e96a0bd 100755
--- a/tests/cp/preserve-gid
+++ b/tests/cp/preserve-gid
@@ -1,7 +1,7 @@
 #!/bin/sh
 # Verify that cp -p preserves GID when it is possible.

-# Copyright (C) 2007 Free Software Foundation, Inc.
+# Copyright (C) 2007, 2008 Free Software Foundation, Inc.

 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -20,6 +20,8 @@
 PRIV_CHECK_ARG=require-root . "$srcdir/../priv-check"
 . "$srcdir/../test-lib.sh"

+. "$abs_top_srcdir/tests/setgid-check"
+
 create() {
   echo "$1" > "$1" || exit 1
   chown "+$2:+$3" "$1" || exit 1