Re: editfiles messing up file permissions?

[Mark . Burgess]

On  3 Jan, Robert Shaw wrote:
> 
> I just upgraded to 1.6.1 and I see this same behavior. Anytime it edits a
> file, it messes with the file ownership/permissions. It always sets them
> to 600. This isn't correct, also the "Umask" option on the editfiles also
> gives me the same "Unknown action" error.
> 
> I'm pretty sure this is a bug. I'm running on Solaris 2.6 on a Sparc station.
> 
> Any ideas???
> 
> Thanks!
> 
>>> it seems that cfengine (version 1.6.1 on Linux) doesn't preserve file
>>> permissions when the file is edited with editfiles. I don't think this
>>> behaviour is correct, at least I didn't expect it to happen. I found
>>> nothing about it in the documentation.
>>
>>
>>This works fine for me - maybe you are not actually using 1.6.1, but
>>an earlier version which contained a bug. The Umask problem
>>would tend to confirm this.
> 


I have just figured out this problem. It only occurs with a
repository defined, which I had not done in trying to find the
bug. Having just reinstalled a system I saw the same thing.
Here is a src/item-file.c replacement which fixes the bug
pending a bugfix release.

Mark

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Work: +47 22453272            Email:  address@hidden
Fax : +47 22453205            WWW  :  http://www.iu.hio.no/~mark
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

item-file.c
Description: Text document