NT patches for cfengine-1.6.0.a11

[Andrews, Martin]

I am thrilled to see that cfengine now is using function prototypes - but I
found a few glitches when building for NT. While I was messing with NT I
tried managing NTFS ACLs with cfengine and found a few glitches. Attached is
a patch to address the following issues:
 
* various prototype bugs - setnetgrent() replacement did not match
prototype, functions passing/returning win32 types should be local to facl.c
(importing windows.h globally leads to namespace clashes - these functions
should
probably be made "static"), don't create empty const macro for ANSI C or C++
(this was causing trouble when including windows headers).
 
* Need to convert filenames to win32 format (from the cygwin/unix format)
when passing to win32 api. For the wish list, it would be really nice if
cfengine understood windows style paths (like c:\temp) - I believe all the
cygwin functions handle these paths, you just need to fix path parsing in
cfengine ... a big task. I began a stab a this and realized the number of
changes were too many, maybe for cfengine 2 the path parsing can be
consolidated into some utility functions that understood windows file paths
as well as unix?
 
* createNTACL() had some memory leaks (not freeing when exceptions occured).
 
Problem not yet fixed: createNTACL currently resets acls with every run
(even if current ACL matches desired) - unlike the Posix ACL manipulation
that only sets the ACL if it differs from the desire (standard cfengine
behavior).
 
Martin 
 
 
 
 

---
Martin Andrews
address@hidden

nt-compile.patch
Description: Binary data