[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
ABI changes in libaspell
From: |
bbhtt |
Subject: |
ABI changes in libaspell |
Date: |
Thu, 22 Aug 2024 19:04:36 +0530 |
User-agent: |
Mozilla Thunderbird |
Hello,
We recently changed the way how we build the GCC compiler for i686 ie. we added
the following build options to GCC `--with-cpu=pentium4, --with-tune=generic
--with-fpmath=sse`.
That change seems to have caused an ABI change in `libaspell.so.15`, as shown
below. The ABI diff report is generated using libabigail [1].
```
┌────────────────────────────┐
│ ABI Break: libaspell.so.15 │
└────────────────────────────┘
Functions changes summary: 2 Removed, 0 Changed, 0 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
2 Removed functions:
[D] 'function acommon::PosibErr<acommon::Decode*>
acommon::get_cache_data<acommon::Decode>(acommon::GlobalCache<acommon::Decode>*,
acommon::ConvBase::CacheConfig*, const acommon::ConvBase::CacheKey&)'
{_ZN7acommon14get_cache_dataINS_6DecodeEEENS_8PosibErrIPT_EEPNS_11GlobalCacheIS3_EEPNS3_11CacheConfigERKNS3_8CacheKeyE}
[D] 'function acommon::PosibErr<acommon::Encode*>
acommon::get_cache_data<acommon::Encode>(acommon::GlobalCache<acommon::Encode>*,
acommon::ConvBase::CacheConfig*, const acommon::ConvBase::CacheKey&)'
{_ZN7acommon14get_cache_dataINS_6EncodeEEENS_8PosibErrIPT_EEPNS_11GlobalCacheIS3_EEPNS3_11CacheConfigERKNS3_8CacheKeyE}
```
It be great to know if this `get_cache_data` actually public API supposed to be
consumed by downstream libraries depending on libaspell or something internally
used by libaspell only.
As far as I can tell the change is coming from `cache.hpp` [2], but the answer
to the previous question is not very apparent to me.
(Please CC me as I'm not on the list)
Thanks!
[1]: https://sourceware.org/libabigail/
[2]:
https://github.com/GNUAspell/aspell/blob/ee6cbb12ff36a1e6618d7388a78dd4e0a2b44041/common/cache.hpp#L14-L23
- bbhtt
https://bbhtt.github.io/